Add option for reloading postfix on changes#28
Open
pecharmin wants to merge 1 commit intobodgit:mainfrom
Open
Conversation
Author
|
Hi @bodgit, kindly asking for a review on this :) I would like to switch from fork to upstream for this puppet module, when the improvement proposed here is merged. |
|
Hi @bodgit, could you merge this PR? |
|
Any progress here, @bodgit? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a system administrator I would like to apply configuration changes to postfix by reloading it.
When using the default service restart behaviour with puppet, the postfix service is restarted.
Rolling out config changes by puppet, could terminate active connections of clients and cause application tasks to fail if those have a poor connection handling.
The module's default service handling is not changed as some users might depend on restarting the service on changes.
Also in some situations a restart of postfix is required to make changes effective: http://www.postfix.org/postconf.5.html